Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: OpenGFX download link did no longer work. #8105

Merged
merged 1 commit into from May 3, 2020
Merged

Conversation

@frosch123
Copy link
Member

@frosch123 frosch123 commented May 1, 2020

Replace it with the link the installer uses, so we notice when that one breaks.

curl -L https://binaries.openttd.org/extra/opengfx/0.5.2/opengfx-0.5.2-all.zip > opengfx-0.5.2-all.zip
unzip opengfx-0.5.2-all.zip
rm -f opengfx-0.5.2-all.zip
curl -L https://binaries.openttd.org/installer/opengfx-1.2.0.7z > opengfx.7z
Copy link
Member

@TrueBrain TrueBrain May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use the installer link. I really like only NSIS uses it, and I really hope we can get ride of that too. It is really annoying to maintain. Also, it is confusing for many. Please use the real OpenGFX version. Tnx :)

LordAro
LordAro approved these changes May 3, 2020
@frosch123 frosch123 merged commit fb5fc0d into OpenTTD:master May 3, 2020
8 checks passed
LordAro added a commit to LordAro/OpenTTD that referenced this issue May 10, 2020
@James103
Copy link
Contributor

@James103 James103 commented May 14, 2020

The URL used to download OpenGFX is still wrong on macOS, as shown in #8146 (MacOS build failed).

@glx22
Copy link
Contributor

@glx22 glx22 commented May 14, 2020

@James103 no it's correct, just not backported yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants