Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8161, e31def197: Lang files may have LF EOL #8163

Merged
merged 1 commit into from May 19, 2020
Merged

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented May 19, 2020

Nightly binaries are built from a source archive made on linux, so using LF EOL. As translations.vbs expects CRLF in lang files, it silently fails to parse them and skip the description lines, generating incomplete, and unusable, ob[gms] files.

Yexo
Yexo approved these changes May 19, 2020
@glx22 glx22 merged commit f6223f8 into OpenTTD:master May 19, 2020
8 checks passed
@glx22 glx22 deleted the fix_8161 branch May 19, 2020
@glx22 glx22 added the backport requested label May 19, 2020
rasputino pushed a commit to rasputino/OpenTTD that referenced this issue Jun 1, 2020
LordAro pushed a commit to LordAro/OpenTTD that referenced this issue Jun 1, 2020
freprec pushed a commit to freprec/OpenTTD that referenced this issue Jun 19, 2020
@LordAro LordAro added backported and removed backport requested labels Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants