Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Realign SDL driver with SDL2 driver to ease maintenance. #8183

merged 1 commit into from Jun 4, 2020


Copy link

Renamed _sdl_screen, reformatted sourcecode, and updated comments so as to allow the two versions of the SDL video driver to be more easily compared and maintained.

src/video/sdl_v.cpp Outdated Show resolved Hide resolved
Copy link

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the long term plan for the SDL1 driver is, it might be going away at some point. But in the meantime, this isn't a bad thing. If it's sticking around though, would be nice to reduce the code duplication further (using member variables to get rid of globals, etc)

Copy link

Thanks for the contribution 😄

@LordAro LordAro merged commit cdd2892 into OpenTTD:master Jun 4, 2020
@techgeeknz techgeeknz deleted the master_sdl_realign branch June 4, 2020 08:54
Copy link
Contributor Author

Once I get my head around OpenTTD's input, video, and windowing systems, I am itching to squash #7006 and other GUI responsiveness issues by redesigning the video and windowing systems to impose hard limits on update times. I don't see any reason why the mouse pointer shouldn't update at least once every 30 ms; and, ideally, the windowing system should feel like it's glued to the mouse button :)

No, I don't expect it to be easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants