Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: More code comment and doxygen fixes. #8184

Merged
merged 2 commits into from Jun 7, 2020

Conversation

@techgeeknz
Copy link
Contributor

@techgeeknz techgeeknz commented Jun 4, 2020

Some aspects of gfx.cpp and the blitter subsystem can certainly use better documentation; however, I am not yet in a position to do this in any meaningful way.

Blitter::DrawLineGeneric() in blitter/common.hpp, in particular, is a real brain bender; I spent a good half hour there and am still not 100% certain how it works.

src/cargopacket.h Outdated Show resolved Hide resolved
@techgeeknz techgeeknz force-pushed the master_docfix branch 5 times, most recently from 21ce965 to c1546ab Jun 4, 2020
@techgeeknz techgeeknz requested a review from LordAro Jun 4, 2020
@techgeeknz
Copy link
Contributor Author

@techgeeknz techgeeknz commented Jun 5, 2020

Sorry about all the force-pushes. I was learning, mostly through trial and error, how to rebase, squash, split, and edit git commits.

@LordAro
Copy link
Member

@LordAro LordAro commented Jun 5, 2020

Just as well, going to need a rebase now :)

@techgeeknz
Copy link
Contributor Author

@techgeeknz techgeeknz commented Jun 5, 2020

Yep. I'll get that sorted next time I'm at my PC. Smartphone probably isn't much good for that sort of thing 😎

@techgeeknz
Copy link
Contributor Author

@techgeeknz techgeeknz commented Jun 6, 2020

It should be good to go now, thanks.

nielsmh
nielsmh approved these changes Jun 6, 2020
LordAro
LordAro approved these changes Jun 7, 2020
@LordAro LordAro merged commit fe19259 into OpenTTD:master Jun 7, 2020
8 checks passed
@techgeeknz
Copy link
Contributor Author

@techgeeknz techgeeknz commented Jun 7, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants