Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adjust .gitignore to CMake build system. #8196

Merged
merged 2 commits into from Jul 10, 2020
Merged

Conversation

@frosch123
Copy link
Member

@frosch123 frosch123 commented Jun 6, 2020

No description provided.


bundle/*
bundles/*
/.vs
Copy link
Member

@LordAro LordAro Jun 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've never allowed editor-specific ignores in the past, why this one?

Copy link
Contributor

@glx22 glx22 Jun 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was project/.vs in previous .gitignore, and we support Visual Studio. And my other addition is also a VS specific one.

Copy link
Member

@LordAro LordAro Jun 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well yes, but by that definition we (now) support everything that cmake can generate. Unless .vs is produced when cmake is run, it shouldn't be there

@LordAro LordAro merged commit db0bf20 into OpenTTD:master Jul 10, 2020
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants