Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 63ccb36e: Incorrect string type for OrderBackup::name save/load #8233

Merged
merged 1 commit into from Jun 22, 2020

Conversation

@JGRennison
Copy link
Contributor

@JGRennison JGRennison commented Jun 21, 2020

In 63ccb36 BaseConsist::name was changed from a malloced char* to a std::string.
OrderBackup inherits from BaseConsist.
The saveload of OrderBackup::name was not updated.
Loading a savegame with an order backup triggers the IsVariableSizeRight assertion.

This savegame contains an order backup: http://www.openttdcoop.org/files/publicserver_archive/PublicServerGame_201_Final.sav

In 63ccb36 BaseConsist::name was changed from a malloced char*
to a std::string.
OrderBackup inherits from BaseConsist.
The saveload of OrderBackup::name was not updated.
@nielsmh nielsmh merged commit e6f3e15 into OpenTTD:master Jun 22, 2020
8 checks passed
8 checks passed
Commit checker
Details
OpenTTD CI Build #20200621.3 succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.9) Linux linux-amd64-clang-3.9 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.