Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 'Huge screenshot' warning being shown incorrectly #8235

Closed
wants to merge 1 commit into from

Conversation

abmyii
Copy link
Contributor

@abmyii abmyii commented Jun 23, 2020

Fixes #8232.

@James103
Copy link
Contributor

@James103 James103 commented Jun 23, 2020

Commit checker has failed. The commit message should be in the form "Fix #8232: ...".

@abmyii
Copy link
Contributor Author

@abmyii abmyii commented Jun 23, 2020

Updated - thanks.

@abmyii abmyii force-pushed the screenshot_warning_8232 branch from 2fd23f5 to a83bd03 Compare Jun 23, 2020
Copy link
Contributor

@nielsmh nielsmh left a comment

Looks correct to me.

Copy link
Contributor

@techgeeknz techgeeknz left a comment

We actually have more than one implementation of the screenshot function, which I'm currently trying to solve. I'll cherry-pick your commit into #8224

@abmyii
Copy link
Contributor Author

@abmyii abmyii commented Jun 26, 2020

We actually have more than one implementation of the screenshot function, which I'm currently trying to solve. I'll cherry-pick your commit into #8224

Cool. I assume this PR should be closed in favour of yours?

@techgeeknz
Copy link
Contributor

@techgeeknz techgeeknz commented Jun 26, 2020

Cool. I assume this PR should be closed in favour of yours?

We'll let the maintainers decide that one. I'll rebase my branch on yours if the cards fall in your favour.

@LordAro
Copy link
Member

@LordAro LordAro commented Jun 27, 2020

Thanks both, I've merged @techgeeknz 's PR

@LordAro LordAro closed this Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants