Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7772: Show destination on mouseover when vehicle stopped (and not in depot) #8236

Merged
merged 1 commit into from Jul 10, 2020

Conversation

@abmyii
Copy link
Contributor

@abmyii abmyii commented Jun 23, 2020

Closes #7772. Added the not in depot condition since newly created vehicles don't have a destination so nothing is shown.

src/vehicle_gui.cpp Outdated Show resolved Hide resolved
@abmyii abmyii force-pushed the abmyii:show_dest_on_mouseover branch from ecece6a to ef6e162 Jun 24, 2020
@LordAro
Copy link
Member

@LordAro LordAro commented Jun 27, 2020

As per original issue, why not use OnHover? Would be nice to actually make use of it :p

@abmyii
Copy link
Contributor Author

@abmyii abmyii commented Jun 27, 2020

As per original issue, why not use OnHover?

#7772 (comment)

Even with the returns disabled, there is no simple way to detect the mouse moving off (as far as I can see).

Would be nice to actually make use of it

It doesn't appear to be used at all - perhaps it's time to deprecate it!

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Jun 28, 2020

As far as I know, OnHover is used for showing tooltips and nothing else. It also only activates after holding the mouse still for a little while, it's not a general "moved the mouse over" event.

@LordAro
LordAro approved these changes Jul 2, 2020
@LordAro LordAro merged commit 7d2db99 into OpenTTD:master Jul 10, 2020
8 checks passed
8 checks passed
Commit checker
Details
OpenTTD CI Build #20200624.1 succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.9) Linux linux-amd64-clang-3.9 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@abmyii abmyii deleted the abmyii:show_dest_on_mouseover branch Jul 10, 2020
@abmyii abmyii restored the abmyii:show_dest_on_mouseover branch Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.