Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8216: Don't show floating text on autoreplace if cost is 0 #8244

Merged
merged 1 commit into from Jun 27, 2020

Conversation

@LordAro
Copy link
Member

LordAro commented Jun 27, 2020

Not actually tested, but it's the only use of the function that isn't already guarded by an "if != 0" check.

@glx22
glx22 approved these changes Jun 27, 2020
Copy link
Contributor

glx22 left a comment

Not tested, but makes sense :)

@LordAro LordAro merged commit 218db00 into OpenTTD:master Jun 27, 2020
8 checks passed
8 checks passed
Commit checker
Details
OpenTTD CI Build #20200627.13 succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.9) Linux linux-amd64-clang-3.9 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@LordAro LordAro deleted the LordAro:bug8216 branch Jun 27, 2020
@techgeeknz
Copy link
Contributor

techgeeknz commented Jun 30, 2020

Not actually tested, but it's the only use of the function that isn't already guarded by an "if != 0" check.

If it's the only function invocation not guarded, and if the guard is important; then why isn't it ShowCostOrIncomeAnimation's responsibility to check its parameter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.