Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GUI rendering (based on JGRPP) #8256

Closed

Conversation

@techgeeknz
Copy link
Contributor

@techgeeknz techgeeknz commented Jul 2, 2020

This is split off from #8217; part 2 of 3.
This should use #8255 as a base.

JGRennison and others added 22 commits Feb 25, 2020
This will need fixups, because the commit checker won't let me indent
a nested #define.
Since they are only ever called with an int and a (int)uint; the
templating seems completely unnecessary and redundant.
This reverts commit 8652a4d.
This is necessary to aid in the cherry-picking of commits from JGRPP.
…g window list.

This is to speed up marking all viewports dirty, which is done very
frequently.
…acked for later redrawing

Track dirty viewport areas seperately form general screen redraws.
Maintain a dirty block grid per viewport, with a smaller block size.
Use even smaller block size in viewport map mode.

Use a rectangle array for general screen redraws instead of a block grid.

Add a dirty bit to windows and widgets, to simplify the common case
of repainting a whole window or widget, without catching
neighbouring windows or viewports.
AddDirtyBlocks is an internal implementation detail of SetDirtyBlocks,
and its name should reflect that.
The viewport cache is transparently managed by the ViewportData struct,
and memory associated with the viewport and cache is automatically
managed using smart pointers.
@techgeeknz techgeeknz closed this Jul 2, 2020
@techgeeknz techgeeknz deleted the techgeeknz:jgr_master_gui_dirty_refactor branch Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.