Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange #8258: Remove unused town cargo caches from the savegame #8258

Merged
merged 1 commit into from Jul 27, 2020

Conversation

@ldpl
Copy link
Contributor

@ldpl ldpl commented Jul 2, 2020

Remove from the savegame Town::cargo_accepted and Town::cargo_produced that were made obsolete by #8159. Also while at it I removed 30 reserved bytes for each town that somehow survived the dff871b purge.

I considered also removing TileMatrix/AcceptanceMatrix but decided to leave it be for now even though atm it's only used to read matrix dimensions as it's still a nice structure that can be useful in the future.

ldpl added a commit to ldpl/OpenTTD that referenced this pull request Jul 2, 2020
@ldpl ldpl force-pushed the ldpl:remove-town-cargo-from-save branch from 6aa8c57 to df048eb Jul 2, 2020
ldpl added a commit to ldpl/OpenTTD that referenced this pull request Jul 7, 2020
@ldpl ldpl force-pushed the ldpl:remove-town-cargo-from-save branch from df048eb to 947a662 Jul 7, 2020
@ldpl ldpl force-pushed the ldpl:remove-town-cargo-from-save branch from 947a662 to f15c551 Jul 7, 2020
@ldpl
Copy link
Contributor Author

@ldpl ldpl commented Jul 7, 2020

Just removed TODO I forgot

@LordAro LordAro merged commit 452e1e3 into OpenTTD:master Jul 27, 2020
8 checks passed
8 checks passed
Commit checker
Details
OpenTTD CI Build #20200707.4 succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.9) Linux linux-amd64-clang-3.9 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@ldpl ldpl deleted the ldpl:remove-town-cargo-from-save branch Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.