Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show the cargoes the vehicles can carry in the list window. #8304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@stormcone
Copy link
Contributor

@stormcone stormcone commented Sep 3, 2020

This patch is based on @KeldorKatarn's commit:
KeldorKatarn/OpenTTD_PatchPack@0a57222

cargo

@James103
Copy link
Contributor

@James103 James103 commented Oct 14, 2020

Should there be a setting to toggle the effects of this PR? Not all players may want this change as it may increase the clutter for some.

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Dec 14, 2020

A setting for this would be the right call, yes, but it can be on by default as far as I am concerned.

You did mangle two patches here, it seems, as I think part of "Feature: Show group name as part of the default vehicle name." is also in here :)

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Dec 15, 2020

You did mangle two patches here, it seems, as I think part of "Feature: Show group name as part of the default vehicle name." is also in here :)

I fixed my issue by merging your other patch. A rebase solves the problem now :D

src/vehicle_gui.cpp Show resolved Hide resolved
src/vehicle_gui.cpp Outdated Show resolved Hide resolved
@frosch123
Copy link
Member

@frosch123 frosch123 commented Dec 15, 2020

Is there somewhere an explanation what this info is used for?

  • Usually all vehicles in a group carry the same cargo, unless they use refit orders, right?
  • Cloning vehicles copies refitting, so it's also unlikely to introduce inconsistencies?

I would see the usefulness of prepending groups names with the cargos of all member vehicles, but I don't understand why someone would want to see it per vehicle.

@stormcone
Copy link
Contributor Author

@stormcone stormcone commented Dec 17, 2020

Its depend on how someone organizes groups or whether using groups at all. The vehicles can be grouped by engines, by stations they visit, etc. But may be it is useful in the "all group" group. For example if you want to see which trains make the lowest profits, you can also whether the cargo makes them not profitable, so maybe better to carry it by other vehicle types.

But maybe sometimes you just would like to see which vehicle carry what when you just browsing the vehicle list. :)

I admit it may be the 'most' useful in the "all group" group. :)

Edit:
It also shows the cargoes in the station and waypoint lists:
openttd_cargo_names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants