Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8313: Correct capitalization on baseset filenames #8322

Closed
wants to merge 1 commit into from

Conversation

@FayneAldan
Copy link

@FayneAldan FayneAldan commented Sep 28, 2020

Updates baseset filenames to use correct capitalization based on original game's file structure. Caused issues on Linux when trying to use the original game's files.

@FLHerne
Copy link

@FLHerne FLHerne commented Oct 15, 2020

This seems odd. Looking at the commit history these files have basically never changed, and there are definitely DOS-graphics users on Linux.

Per the comments on a similar (ancient!) bug #2408, this is supposed to be a case-insensitive lookup on Linux also. That must have broken at some point, and I think fixing it there would be more reliable than this change.

EDIT: That said, this seems reasonable for consistency if nothing else.

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Dec 15, 2020

The code tries to open files first based on the capitalization used by the source; if that fails it tries again with everything in lowercase. So that means that many of the cases in this PR should not be needed; a few are worth checking out, and might have caused the problem: they are lowercase in the source, and appear to be uppercase in the DOS archive.

I will investigate this a bit further.

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Dec 15, 2020

Confirmed. Only lowercase -> uppercase should happen. Created new PR to address only those. Going to close this one now in favour of that one.

Thank you for figuring out what the problem was! Hope you don't mind I solved it this way :D

@TrueBrain TrueBrain closed this Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants