Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH Actions CI workflow #8323

Merged
merged 3 commits into from Oct 3, 2020
Merged

Add GH Actions CI workflow #8323

merged 3 commits into from Oct 3, 2020

Conversation

@LordAro
Copy link
Member

@LordAro LordAro commented Sep 29, 2020

Largely copied one-for-one from the azure pipeline jobs. Except the windows job, which @glx22 did.

Doesn't check x86 on Linux. Should it? idk.

Removes the need for the ci-* docker images in OpenTTD/CompileFarm

@LordAro
Copy link
Member Author

@LordAro LordAro commented Sep 29, 2020

Of course, the existing Azure CI is sad because it's been removed..

@LordAro LordAro requested a review from glx22 Sep 29, 2020
@glx22
glx22 approved these changes Sep 30, 2020
Copy link
Contributor

@glx22 glx22 left a comment

Seems to work as expected.
Problem matchers could be a nice addition, but no hurry.

@LordAro
Copy link
Member Author

@LordAro LordAro commented Sep 30, 2020

Problem matchers?

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Sep 30, 2020

Tips and tricks to get started on problem matchers (but, really, for another PR):

Example of how to enable them:
https://github.com/TrueBrain/actions-flake8/blob/master/entrypoint.sh#L6

Example of a GCC Problem Matcher:
https://github.com/microsoft/vscode-cpptools/blob/master/Extension/package.json#L98

Or implemented in a GitHub Action:
https://github.com/ammaraskar/gcc-problem-matcher

@glx22
Copy link
Contributor

@glx22 glx22 commented Sep 30, 2020

I also found https://github.com/ammaraskar/msvc-problem-matcher but as already said, it can wait for another PR.

@LordAro LordAro merged commit bef9e3f into OpenTTD:master Oct 3, 2020
6 checks passed
6 checks passed
Linux (clang)
Details
Commit checker
Details
Linux (gcc)
Details
Windows (x86)
Details
Windows (x64)
Details
Mac OS
Details
@LordAro LordAro deleted the LordAro:actions branch Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants