Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add problem matchers to CI #8324

Merged
merged 2 commits into from Oct 10, 2020
Merged

Add problem matchers to CI #8324

merged 2 commits into from Oct 10, 2020

Conversation

@LordAro
Copy link
Member

@LordAro LordAro commented Oct 3, 2020

No description provided.

@glx22
Copy link
Contributor

@glx22 glx22 commented Oct 7, 2020

So repo.msys2.org seems to be back. But while it was down I tried some stuff to auto update vcpkg, and it was not very easy to do using run-vcpkg action, so I ended rewriting windows workflow (see here). I also fixed linux failure.

@LordAro LordAro force-pushed the LordAro:problem-matchers branch from 3e48aba to e9a970c Oct 10, 2020
@LordAro LordAro force-pushed the LordAro:problem-matchers branch from 5af3541 to 3041b15 Oct 10, 2020
@LordAro LordAro requested review from glx22 and TrueBrain Oct 10, 2020
@LordAro
Copy link
Member Author

@LordAro LordAro commented Oct 10, 2020

Would you say that "doing it ourselves" is better than using the run-vcpkg action?

@glx22
Copy link
Contributor

@glx22 glx22 commented Oct 10, 2020

run-vcpkg action doesn't seem to support automatic update for vcpkg without a trick (using git fetch and giving FETCH_HEAD to run-vcpkg).
It's also possible to force the vcpkg commit id to use, but that means we must change it whenever we want to upgrade vcpkg or one of the libs we need.

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Oct 10, 2020

I would suggest we first ask the action-maintainer to add the ability to do this; we cannot be the only one who would like this :) As I make actions myself, I always truly appreciate others asking for their use-case .. it improves actions for all :)

@LordAro LordAro merged commit 13e1b13 into OpenTTD:master Oct 10, 2020
6 checks passed
6 checks passed
Linux (clang)
Details
Commit checker
Details
Linux (gcc)
Details
Windows (x86) Windows (x86)
Details
Windows (x64) Windows (x64)
Details
Mac OS Mac OS
Details
@LordAro LordAro deleted the LordAro:problem-matchers branch Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants