Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: useless warning with -snull and no BaseSounds available #8361

Merged
merged 1 commit into from Dec 8, 2020

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Dec 6, 2020

If I explicitly tell the system I do not want sound, I still get
presented a nice message I do not have any BaseSounds available
on my system, and that I should download one to enjoy sound. Well,
let me tell you, with "-snull" that is really really not going to
help. So please, be quiet, and let me enjoy the game without
"boooooo" and "DING DING DING".

Thank you.

@glx22
Copy link
Contributor

@glx22 glx22 commented Dec 6, 2020

Can't use something similar to video drivers HasGUI() ?

@TrueBrain
Copy link
Member Author

@TrueBrain TrueBrain commented Dec 6, 2020

Can't use something similar to video drivers HasGUI() ?

Meh; you are going to make me do work ... yes, it can, and it is nicer .. but ... WORK! :P Will do :)

If I explicitly tell the system I do not want sound, I still get
presented a nice message I do not have any BaseSounds available
on my system, and that I should download one to enjoy sound. Well,
let me tell you, with "-snull" that is really really not going to
help. So please, be quiet, and let me enjoy the game without
"boooooo" and "DING DING DING".

Thank you.
@TrueBrain TrueBrain force-pushed the silent_no_sound branch from c74b254 to 982cd61 Dec 7, 2020
LordAro
LordAro approved these changes Dec 8, 2020
@TrueBrain TrueBrain merged commit 2864d01 into OpenTTD:master Dec 8, 2020
6 checks passed
@TrueBrain TrueBrain deleted the silent_no_sound branch Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants