Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8313: use correct capitalization for TTO / DOS base-music #8385

Merged
merged 1 commit into from Dec 15, 2020

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Dec 15, 2020

DOS did not have cases in filenames. Different OS interpret
them as either all-lowercase or all-uppercase. So we try both.
All-uppercase is done by the obg/obm/obs files, and if opening
fails, OpenTTD will automatically retry the all-lowercase variant.

So for those who already have the files lowercase, nothing
changes. For those that install fresh from TTO, it should now
work out-of-the-box.


This is an alternative to #8322, which also changed a lot of entries to lowercase. This seems to be the wrong move: in the way OpenTTD works, lowercase is always checked anyway.

@frosch123
Copy link
Member

@frosch123 frosch123 commented Dec 15, 2020

Ah, I forgot that OpenTTD tries lowercase as well. So this works no matter whether the OS changes the case for old DOS-uppercase-only filenames :)

frosch123
frosch123 previously approved these changes Dec 15, 2020
DOS did not have cases in filenames. Different OS interpret
them as either all-lowercase or all-uppercase. So we try both.
All-uppercase is done by the obg/obm/obs files, and if opening
fails, OpenTTD will automatically retry the all-lowercase variant.

So for those who already have the files lowercase, nothing
changes. For those that install fresh from TTO, it should now
work out-of-the-box.
@TrueBrain TrueBrain merged commit 88f30f7 into OpenTTD:master Dec 15, 2020
8 checks passed
@TrueBrain TrueBrain deleted the gm_casing branch Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants