Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: next 67 savegame versions are used in PatchPacks; skip them #8411

Merged
merged 1 commit into from Dec 22, 2020

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Dec 22, 2020

Various of PatchPacks (Spring 2013, Joker, ChillPP) used versions
slightly higher than ours. Of course, as time went by, this
caught up with us, and we are now almost pushing a new version
that would conflict with them. To avoid users creating unneeded
issues about "why can I not load my savegame", lets be ahead of
the curve and flat-out refuse to load them.

Version-wise, this is totally fine. We have ~32k versions to go
before we run out (0x8000 is masked by JGRPP; we should avoid
using that). At the rate we bump savegames, this is not going to
happen in any sane reality.

Fixes #8116 (well, rather, it prevents, but GitHub understands fixes :P)

Various of PatchPacks (Spring 2013, Joker, ChillPP) used versions
slightly higher than ours. Of course, as time went by, this
caught up with us, and we are now almost pushing a new version
that would conflict with them. To avoid users creating unneeded
issues about "why can I not load my savegame", lets be ahead of
the curve and flat-out refuse to load them.

Version-wise, this is totally fine. We have ~32k versions to go
before we run out (0x8000 is masked by JGRPP; we should avoid
using that). At the rate we bump savegames, this is not going to
happen in any sane reality.
@TrueBrain
Copy link
Member Author

@TrueBrain TrueBrain commented Dec 22, 2020

@JGRennison : this should be fine with JGRPP too, right?

Copy link
Member

@LordAro LordAro left a comment

Sure, why not.

@JGRennison
Copy link
Contributor

@JGRennison JGRennison commented Dec 22, 2020

@JGRennison : this should be fine with JGRPP too, right?

This is fine with me. I've got no objections.

@TrueBrain TrueBrain merged commit d8c8f4e into OpenTTD:master Dec 22, 2020
8 checks passed
@TrueBrain TrueBrain deleted the savegame_version branch Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants