Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Simplify GetRailDepotTrack. #8451

Closed
wants to merge 1 commit into from

Conversation

J0anJosep
Copy link
Contributor

@J0anJosep J0anJosep commented Dec 27, 2020

Motivation / Problem

Description

Rail depot track can be checked with only 1 bit.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@michicc
Copy link
Member

@michicc michicc commented Dec 29, 2020

I'm inclined to close this PR as I (1) like the explicit way more (semantically map stores DiagDirection and not Track), and (2), any good optimizer will reduce it to a single bit test anyway: https://godbolt.org/z/sq9o4E

@michicc michicc closed this Dec 29, 2020
@J0anJosep
Copy link
Contributor Author

@J0anJosep J0anJosep commented Dec 29, 2020

I'm inclined to close this PR as I (1) like the explicit way more (semantically map stores DiagDirection and not Track), and (2), any good optimizer will reduce it to a single bit test anyway: https://godbolt.org/z/sq9o4E

Thank you. I'll try to have that in mind from now on.

@J0anJosep J0anJosep deleted the SimplifyGetRailDepTrack branch Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants