Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Assert fail when using restart command after opening save/load GUI #8464

Merged
merged 1 commit into from Dec 29, 2020

Conversation

JGRennison
Copy link
Contributor

@JGRennison JGRennison commented Dec 29, 2020

Motivation / Problem

Use of the restart console command and network auto-restarting (NetworkCheckRestartMap) after opening the save/load window triggers an assertion failure.

Example reproduction steps:

  1. Start a new game
  2. Open the load game window (but don't actually load anything)
  3. Run restart in the console

Description

ShowSaveLoadDialog incorrectly overwrites the value of _file_to_saveload.abstract_ftype.
This value is used by the restart console command and by NetworkCheckRestartMap.

The value of the _file_to_saveload.abstract_ftype must be consistent with the other members of _file_to_saveload.

Limitations

N/A

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@michicc michicc merged commit 15fd63b into OpenTTD:master Dec 29, 2020
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants