Fix #8462: Don't check whether to grow a town road on water

[SamuXarick]

Motivation / Problem

#8462
With Original or Better Roads town layout, towns are testing whether they can build a road at a tile for future use, but the command omits the DC_NO_WATER flag, which mean that on full clear water tiles, such as sea, river or canal with no owner, the command would return true.

I'm not a town growth expert, but I don't think towns are supposed to be clearing water tiles to expand on them.

Description

I think the problem is solved by using DC_NO_WATER flag on this situation.

Limitations

I have no great knowledge of town growth code, but with some tests, towns grow differently with the fix in, when they're near river tiles. But I'm not really sure of the whole impact of this change.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

• The bug fix is important enough to be backported? (label: 'backport requested')
• This PR affects the save game format? (label 'savegame upgrade')
• This PR affects the GS/AI API? (label 'needs review: Script API')
  • ai_changelog.hpp, gs_changelog.hpp need updating.
  • The compatibility wrappers (compat_*.nut) need updating.
• This PR affects the NewGRF API? (label 'needs review: NewGRF')
  • PR must be added to API tracker

[LordAro]

Looked at the code a bit, and I'm 90% certain that adding DC_NO_WATER to CMD_BUILD_ROAD does nothing - it only has an effect for the CLEAR_LANDSCAPE

Seems reasonable otherwise

[SamuXarick]

Looked at the code a bit, and I'm 90% certain that adding DC_NO_WATER to CMD_BUILD_ROAD does nothing - it only has an effect for the CLEAR_LANDSCAPE

Seems reasonable otherwise

LordAro, CMD_BUILD_ROAD also ends up running CMD_LANDSCAPE_CLEAR and inherits the DC flags from the source.
Without DC_NO_WATER, CMD_BUILD_ROAD calls CMD_LANDSCAPE_CLEAR and reaches ClearTile_Water which say it is possible to clear the water. If the command was run in DC_EXEC mode, you would see rivers being demolished and replaced with roads

[TrueBrain]

"Should be fine" (famous last words, looking at @LordAro :P :P ).

DC_NO_WATER is indeed forwarded to CMD_LANDSCAPE_CLEAR, so this should have an effect.

The order of these commands is very odd, but .. not going to touch that now :)