Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: [OSX] Prevent the compiler from using SSE4 instructions unless we want to. #8476

Merged
merged 1 commit into from Jan 2, 2021

Conversation

@michicc
Copy link
Member

@michicc michicc commented Jan 2, 2021

Motivation / Problem

Apple clang might default to use SSE4 instructions in the optimizer that don't work on old systems.

Description

Tell the compiler to not use SSE4 in general, except for those files where we specifically want it.

Limitations

We might loose a tiny fraction of performance on newer systems.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
…nless we want to.

This improves compatibility on older systems. We don't need to disable anything
older, as there are no SSE2-only Macs.
Copy link
Member

@TrueBrain TrueBrain left a comment

Let's just ship this, assuming it fixes the problems for older machines :)

@michicc michicc merged commit 5b1fb94 into OpenTTD:master Jan 2, 2021
9 checks passed
9 checks passed
Check for preview label
Details
Check for preview label
Details
Emscripten
Details
Commit checker
Details
Linux (clang, clang++)
Details
Linux (gcc, g++)
Details
Mac OS (x64, x86_64) Mac OS (x64, x86_64)
Details
Windows (x86) Windows (x86)
Details
Windows (x64) Windows (x64)
Details
@michicc michicc deleted the michicc:pr/osx_sse branch Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants