Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSX] Video driver code cleanup #8479

Merged
merged 5 commits into from Jan 3, 2021
Merged

[OSX] Video driver code cleanup #8479

merged 5 commits into from Jan 3, 2021

Conversation

@michicc
Copy link
Member

@michicc michicc commented Jan 2, 2021

Motivation / Problem / Description

Some code cleanup gathering dust.

Incidentally, it might fix the potential crash in SetPortAlphaOpaque because that function is gone in it's current form due to being useless.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
michicc added 5 commits Dec 26, 2020
…ll drawing code and moving the window/event handling to a different file.

This is just a code move/rename, not a functionality change.
…de and instead simply initialise the buffer on allocation.
This separates the OSX specific files into a proper folder when generating
Xcode project files.
@michicc michicc force-pushed the michicc:pr/osx_cleanup branch from 91299fc to e204520 Jan 2, 2021
@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Jan 3, 2021

Compiles and runs fine for me. macOS 10.15.7.

Noticed that it fixes smearing of window contents (random pixel noise) when resizing windows.

Copy link
Member

@TrueBrain TrueBrain left a comment

If it works for andy, it is good enough for me! :D

@michicc michicc merged commit 21a4516 into OpenTTD:master Jan 3, 2021
8 checks passed
8 checks passed
Emscripten
Details
Commit checker
Details
Check preview needs update Check preview needs update
Details
Linux (clang, clang++)
Details
Linux (gcc, g++)
Details
Mac OS (x64, x86_64)
Details
Windows (x86) Windows (x86)
Details
Windows (x64) Windows (x64)
Details
@michicc michicc deleted the michicc:pr/osx_cleanup branch Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants