Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: use our search-paths to find fonts based on relative filenames too #8482

Merged
merged 1 commit into from Jan 2, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 2, 2021

Fixes #7830

Motivation / Problem

Given how OpenTTD works, you would expect that you can put ttf files in your PERSONAL_DIR, and that the game can find that. This was not the case, as we never looked in our search-paths for the ttf.
This PR addresses that issue.

Description

This allows "small_font = ./myfont.ttf", with "myfont.ttf" located
in "~/.openttd".

Tested on both Linux and Windows.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
This allows "small_font = ./myfont.ttf", with "myfont.ttf" located
in "~/.openttd".
@michicc
michicc approved these changes Jan 2, 2021
@michicc michicc merged commit 4bd3d18 into OpenTTD:master Jan 2, 2021
8 checks passed
8 checks passed
Emscripten
Details
Commit checker
Details
Check preview needs update Check preview needs update
Details
Linux (clang, clang++)
Details
Linux (gcc, g++)
Details
Mac OS (x64, x86_64) Mac OS (x64, x86_64)
Details
Windows (x86) Windows (x86)
Details
Windows (x64) Windows (x64)
Details
@TrueBrain TrueBrain deleted the TrueBrain:font_search_path branch Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants