Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [OSX] Register fonts loaded directly from disk for text layout #8484

Merged
merged 1 commit into from Jan 3, 2021

Conversation

@michicc
Copy link
Member

@michicc michicc commented Jan 2, 2021

Motivation / Problem

Unicode text layout on OSX is done by CoreText, which only uses font data registered with CoreText.

Description

Register font that are loaded from file and not the OS store with CoreText.

Limitations

Interacts with #8482. FreeType and OSX CoreText might still not agree pixel-perfect.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@michicc michicc force-pushed the michicc:pr/osx_font_reg branch from 9515d61 to 0a191ac Jan 2, 2021
…th CoreText for proper text layout.
@michicc michicc force-pushed the michicc:pr/osx_font_reg branch from 0a191ac to 99d5fe7 Jan 2, 2021
@LordAro
LordAro approved these changes Jan 2, 2021
@michicc michicc merged commit 8c24b2b into OpenTTD:master Jan 3, 2021
8 checks passed
8 checks passed
Emscripten
Details
Commit checker
Details
Check preview needs update Check preview needs update
Details
Linux (clang, clang++)
Details
Linux (gcc, g++)
Details
Mac OS (x64, x86_64) Mac OS (x64, x86_64)
Details
Windows (x86) Windows (x86)
Details
Windows (x64) Windows (x64)
Details
@michicc michicc deleted the michicc:pr/osx_font_reg branch Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants