Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [OSX] don't show top OS menu bar when in full screen #8486

Closed
wants to merge 1 commit into from

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 3, 2021

Fixes #8038.

Motivation / Problem

#8038 has a good movie showing the issue.

Description

Solution given by #8038 (comment) and confirmed by https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/LaunchServicesKeys.html#//apple_ref/doc/uid/20001431-113616 .

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Jan 3, 2021

Testing the bundled macOS package:

  1. When opening in windowed mode, the macOS menu bar is missing. 1.10.2 release does not do this.

8486-1

  1. Cursor is 'trapped' when moving the pointer upwards, really needs a video to explain it. This is a pre-existing issue visible in 1.10.2, but looks worse with this PR because the mouse position is invisible. In 1.10.2 the OS menu bar appears and the system cursor appears, so perceptually it's less bad. cursor-trap

Full-screen mode does hide the OS menu bar.
Truebrain asked if this PR also addresses #8067 - it doesn't.

@TrueBrain
Copy link
Member Author

@TrueBrain TrueBrain commented Jan 3, 2021

I was hoping this setting would only influence full-screen applications .. but for some reason it also does windowed .. which is not what I expected. I will leave MacOS development to the pros ;)

@TrueBrain TrueBrain closed this Jan 3, 2021
@TrueBrain TrueBrain deleted the TrueBrain:osx_fullscreen branch Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants