Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSX] Fullscreen improvments #8487

Merged
merged 2 commits into from Jan 3, 2021
Merged

[OSX] Fullscreen improvments #8487

merged 2 commits into from Jan 3, 2021

Conversation

@michicc
Copy link
Member

@michicc michicc commented Jan 3, 2021

Fixes #8038

Motivation / Problem

The menu bar gets in the way in OSX fullscreen mode.
Also, quitting while in fullscreen mode looses the original window size, unlike e.g. under Windows.

Description

Hide Dock and menu bar in fullscreen mode and store the original windows size in the config, not the fullscreen size.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@michicc michicc force-pushed the michicc:pr/osx_fs branch from b8fe942 to 3d993d1 Jan 3, 2021
michicc added 2 commits Jan 3, 2021
…w size.

This replicates the behaviour on e.g. Windows, which saves the original window size.
@michicc michicc force-pushed the michicc:pr/osx_fs branch from 3d993d1 to ce1acf7 Jan 3, 2021
@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Jan 3, 2021

Works as expected for me

  • full screen has no menu bar
  • full does not show dock
  • behaviour is conventional for macOS when switching to/from OpenTTD in full screen mode
  • window sizing is retained across restarts for variations of full screen / windowed
  • tested for both ./openttd, and the bundle package built with cpack

macOS 10.15.7

@michicc michicc merged commit 4ce53cb into OpenTTD:master Jan 3, 2021
8 checks passed
8 checks passed
Emscripten
Details
Commit checker
Details
Check preview needs update Check preview needs update
Details
Linux (clang, clang++)
Details
Linux (gcc, g++)
Details
Mac OS (x64, x86_64)
Details
Windows (x86) Windows (x86)
Details
Windows (x64) Windows (x64)
Details
@michicc michicc deleted the michicc:pr/osx_fs branch Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants