Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup engine randomisation #8488

Merged
merged 2 commits into from Jan 3, 2021
Merged

Cleanup engine randomisation #8488

merged 2 commits into from Jan 3, 2021

Conversation

@frosch123
Copy link
Member

@frosch123 frosch123 commented Jan 3, 2021

Motivation / Problem

Reading an earlier commit threw ENoSense. This tries to finish the work.

Description

  • 8139b14 inserted some code between a comment and the code the comment belonged to. So the comment lost any meaning.
  • 9f42358 separated introduction-date randomisation from reliability randomisation, but only succeeded with that in 5 of 6 cases.

Limitations

None

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@michicc
michicc approved these changes Jan 3, 2021
@LordAro
LordAro approved these changes Jan 3, 2021
@LordAro LordAro merged commit b08d8c7 into OpenTTD:master Jan 3, 2021
7 checks passed
7 checks passed
Emscripten
Details
Commit checker
Details
Linux (clang, clang++)
Details
Linux (gcc, g++)
Details
Mac OS (x64, x86_64)
Details
Windows (x86) Windows (x86)
Details
Windows (x64) Windows (x64)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants