Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8067: [OSX] Calculate title bar height instead of assuming a fixed value #8491

Merged
merged 2 commits into from Jan 3, 2021

Conversation

@michicc
Copy link
Member

@michicc michicc commented Jan 3, 2021

Motivation / Problem

Title bar height is not 22 pixel in fullscreen mode.

Description

Get the real title bar height instead.

The fix for #8067 solves the real issue, making this workaround unneeded.
@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Jan 3, 2021

Tested on macOS 10.15.7, works for me, fixes #8067

@michicc michicc merged commit 979b4af into OpenTTD:master Jan 3, 2021
8 checks passed
8 checks passed
Emscripten
Details
Commit checker
Details
Check preview needs update Check preview needs update
Details
Linux (clang, clang++)
Details
Linux (gcc, g++)
Details
Mac OS (x64, x86_64)
Details
Windows (x86) Windows (x86)
Details
Windows (x64) Windows (x64)
Details
@michicc michicc deleted the michicc:pr/issue_8067 branch Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants