Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7604: prevent houses to wander too far from town center when rebuilding #8507

Merged
merged 1 commit into from Jan 7, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 6, 2021

Motivation / Problem

As described in #7604, a bug that existed since TTO. It is a funny little bug, and depending on how lucky you are, houses could wander off endlessly. This simple approach resolve the wandering around.

Description

When a multi-tile house is rebuild, it always used the most northern
tile to build the new house. This can very easily lead to houses
wandering off in the north-ish direction (either NW or NE).

To prevent this, pick the tile closest to town center when rebuilding
on a multi-tile house. This still means a house can be build away
from a road, but it is no longer wandering around finding another
town to call home.

If you want to see for yourself that this works, best to use the following savegame:
issue-7604.zip

It is somewhat prepared to show the worst of this all ;) Just load it in, unpause, fast forward, and once in a while send some funds to the town. If you want to test this faster, change line 624 to:

t->time_until_rebuild = 1;

And line 629 to:

if (true || GB(r, 24, 8) >= 12) {

Now you have some speedy rebuilds on your hands!

Limitations

  • This does not prevent a house from being build while not next to a road. That could be added, but requires a lot more complex code, which was not worth the effort in my opinion.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
…uilding

When a multi-tile house is rebuild, it always used the most northern
tile to build the new house. This can very easily lead to houses
wandering off in the north-ish direction (either NW or NE).

To prevent this, pick the tile closest to town center when rebuilding
on a multi-tile house. This still means a house can be build away
from a road, but it is no longer wandering around finding another
town to call home.
@TrueBrain TrueBrain added this to the 1.11.0 milestone Jan 6, 2021
@LordAro
LordAro approved these changes Jan 6, 2021
@TrueBrain TrueBrain merged commit c7609e7 into OpenTTD:master Jan 7, 2021
7 checks passed
7 checks passed
Emscripten
Details
Commit checker
Details
Linux (clang, clang++)
Details
Linux (gcc, g++)
Details
Mac OS (x64, x86_64)
Details
Windows (x86) Windows (x86)
Details
Windows (x64) Windows (x64)
Details
@TrueBrain TrueBrain deleted the TrueBrain:wandering-houses branch Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants