Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8068: always allow removal of tram track if that generates money #8509

Merged
merged 1 commit into from Jan 7, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 6, 2021

Motivation / Problem

Even if you are completely broke, generating money should always
be allowed.

Description

The code assumed it would always cost something to remove road-parts .. this is no longer the case.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
Even if you are completely broke, generating money should always
be allowed.
@TrueBrain TrueBrain added this to the 1.11.0 milestone Jan 6, 2021
@LordAro
LordAro approved these changes Jan 6, 2021
@TrueBrain TrueBrain merged commit 1b675e7 into OpenTTD:master Jan 7, 2021
7 checks passed
7 checks passed
Emscripten
Details
Commit checker
Details
Linux (clang, clang++)
Details
Linux (gcc, g++)
Details
Mac OS (x64, x86_64)
Details
Windows (x86) Windows (x86)
Details
Windows (x64) Windows (x64)
Details
@TrueBrain TrueBrain deleted the TrueBrain:road-money-2 branch Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants