Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8168: allow relocating of HQ partial over existing HQ #8510

Merged
merged 1 commit into from Jan 6, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 6, 2021

Motivation / Problem

Someone had an itch. It was small enough to scratch. What is there to say?

Description

Just in case you want to move it SLIGHTLY to the right.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@TrueBrain TrueBrain added this to the 1.11.0 milestone Jan 6, 2021
@James103
Copy link
Contributor

@James103 James103 commented Jan 6, 2021

Again, the regression tests need to be updated.

@TrueBrain
Copy link
Member Author

@TrueBrain TrueBrain commented Jan 6, 2021

Again, the regression tests need to be updated.

Again, I know :) The CI is already telling me ;) Stop making me feel worse about doing my job poorly already :P

(PS: GitHub sends me mails when CI fails, so it is really hard to miss for me :D)

Just in case you want to move it SLIGHTLY to the right.
@TrueBrain TrueBrain force-pushed the TrueBrain:move-hq branch from b1c7238 to 2c8a1ed Jan 6, 2021
@TrueBrain TrueBrain merged commit 28c13ec into OpenTTD:master Jan 6, 2021
8 checks passed
8 checks passed
Emscripten
Details
Commit checker
Details
Check preview needs update Check preview needs update
Details
Linux (clang, clang++)
Details
Linux (gcc, g++)
Details
Mac OS (x64, x86_64)
Details
Windows (x86) Windows (x86)
Details
Windows (x64) Windows (x64)
Details
@TrueBrain TrueBrain deleted the TrueBrain:move-hq branch Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants