Fix a bug in "restart" and introduce "reload" console command #8527
Motivation / Problem
#7328 missed a case where a new game doesn't reset
#8469, despite the way of wording, does have a point, which was already brought up in a comment in the original PR. Basically, "restart" and "reload" really are two different words, with different meaning. The new "restart" as accepted by #7328 acted in a way many people would not expect, especially as you are already used to the old one.
To top it off, the console command help-text was never changed, making it even more confusing.
In this PR I opted to revert the change to "restart" from #7328, and reintroduce it as "reload". As we haven't had a release since the introduction of that PR, this should be fine. Now people who are used to the way the old command worked, can keep using it that way. Those who fancy the new way, can use that to.
In my world, the naming makes more sense this way:
This was echo'd by several comments in #7328.
I went through these use-case:
But most of all, I find it very weird to so drastically change an existing console command between 2 releases, without having a good argument not to name the new way different. The ones given in #7328 were not convincing to me, at all. But, truth be told, this is a personal itch, as I was mostly annoyed the help text was not updated to reflect reality :)
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.
Things to not forget after merge
In the sequence: - Load a game - Start a newgame (via console) - Restart a game (via console) Gave you the loaded game back, not the new game.
The current "restart" command is now called "reload", as that is what it does. The old "restart" command is now called "restart", as that is what it did. As this has not been in any official release yet, this shouldn't harm any kitten.