Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: warning in cheat window #8538

Merged
merged 1 commit into from Jan 9, 2021
Merged

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 8, 2021

Fixes #8034

Motivation / Problem

17 years later, and the joke has aged poorly.

Description

Although meant as a funny joke towards the player, our social
standards have changed since 2004, and such "jokes" are no
longer acceptable by the community as a whole.

It also serves absolutely no purpose, other than trying to be
funny. Let's keep the jokes to funny people, so we can concentrate
on a good game :)

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@@ -1837,7 +1837,6 @@ STR_ABANDON_SCENARIO_QUERY :{YELLOW}Are you
# Cheat window
STR_CHEATS :{WHITE}Cheats
STR_CHEATS_TOOLTIP :{BLACK}Checkboxes indicate if you have used this cheat before
STR_CHEATS_WARNING :{BLACK}Warning! You are about to betray your fellow competitors. Keep in mind that such a disgrace will be remembered for eternity
Copy link
Contributor

@James103 James103 Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As STR_CHEATS_WARNING is being removed in this PR, would it be great if you had a Update: Disuse of STR_CHEATS_WARNING or a similar commit as the string is translated to multiple languages?

Copy link
Member Author

@TrueBrain TrueBrain Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have eints for that. After this PR is merged, the next time he comes around, he removes the string from allll the other languages. We mere mortals don't have to spend time on that; we outsourced it :D

@LordAro
Copy link
Member

@LordAro LordAro commented Jan 9, 2021

I disagree with removing the message entirely, though I do agree it could be reworded. Perhaps "Note that any usage of these settings will be recorded by the savegame" ?

@TrueBrain
Copy link
Member Author

@TrueBrain TrueBrain commented Jan 9, 2021

I disagree with removing the message entirely, though I do agree it could be reworded. Perhaps "Note that any usage of these settings will be recorded by the savegame" ?

We talked a bit about this on IRC. Basically, I do not see what the value is in telling people about this behaviour, and I was even tempted to just completely remove it (not store if someone used cheats). But for debugging purposes it is kinda useful that the information is stored. So I guess? At least not in the same location and in the form it was done, as I basically didn't even notice the text, as my mind immediately dismissed it as "ads". It is funny how our brains are primed to skip parts of windows we expect carry no value :D

I will see what I can do.

@TrueBrain
Copy link
Member Author

@TrueBrain TrueBrain commented Jan 9, 2021

image

Seems to make more sense to me. Notes go at the bottom, made it prettier than just random text dumped in the window, and it just tells you a fact, not a judgement.

src/cheat_gui.cpp Outdated Show resolved Hide resolved
@frosch123
Copy link
Member

@frosch123 frosch123 commented Jan 9, 2021

Not sure how much work you want to put into this. But the GUI would probably be prettier, if you insert vertical space (WD_PAR_VSEP_NORMAL) over the first item. Can't remember whether the widgets support padding by themself.

Although meant as a funny joke towards the player, our social
standards have changed since 2004, and such "jokes" are no
longer acceptable by the community as a whole.

The only value of the message is that people are informed the
information is stored in the savegame. This is mostly useful for
us, developers, as some of those cheats can have side-effects
which people report.

While at it, styled the GUI a bit better, as the way the text
was presented was odd.
@frosch123 frosch123 added the preview label Jan 9, 2021
@TrueBrain TrueBrain merged commit 3dbdb1c into OpenTTD:master Jan 9, 2021
9 checks passed
@TrueBrain TrueBrain deleted the remove_cheat_stoe branch Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants