Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: darken the background of all graph to increase contrast #8542

Closed
wants to merge 1 commit into from

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 9, 2021

Fixes #8539.

Motivation / Problem

Some company graph colours are very hard to read, making you want to change your company colour.

See #8539 for a detailed explanation.

Description

For the current choice, colours like Mauve, Dark Green and Purple
are nearly invisible in the graphs. Using a darker background
resolves that issue.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

For the current choice, colours like Mauve, Dark Green and Purple
are nearly invisible in the graphs. Using a darker gradient
resolves that issue.
@TrueBrain TrueBrain added the preview label Jan 9, 2021
LordAro
LordAro approved these changes Jan 9, 2021
Copy link
Member

@LordAro LordAro left a comment

1 character fixes good

@TrueBrain
Copy link
Member Author

@TrueBrain TrueBrain commented Jan 9, 2021

This is just moving the issue around .. I don't like my own solution :D I need to think about this a bit more ...

@TrueBrain TrueBrain closed this Jan 9, 2021
@frosch123
Copy link
Member

@frosch123 frosch123 commented Jan 9, 2021

Going by the screenshots in #8539, changing the background to black should have the biggest impact.
Except for some Pikka GRF, none of the colours are particulary black-ish. While medium grey conflicts with everything by definition.

@TrueBrain TrueBrain changed the title Change: use a darker gradient colour for company colours on graphs Change: darken the background of all graph to increase contrast Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants