Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8272: vehicle destination text colour when mousing over #8543

Merged
merged 1 commit into from Jan 9, 2021

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 9, 2021

Fixes #8272.

Motivation / Problem

When a vehicle is stopped, mouse-over shows the destination. It is only in blue, which is rather confusing, as you think it is going. It is not, it is just showing you where it wants to go. So, instead, make the text red if it is stopped.

Equally, make it orange if it doesn't have a free path.

Description

I just cherry-picked from JGRPP:
JGRennison/OpenTTD-patches@c35f620
JGRennison/OpenTTD-patches@7aead21

Why solve it again, if someone else already did! Tnx @JGRennison !

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain added this to the 1.11.0 milestone Jan 9, 2021
LordAro
LordAro approved these changes Jan 9, 2021
Copy link
Member

@LordAro LordAro left a comment

Mildly concerns me that the text_colour variable is defined 100 lines away from where it is ultimately used, but that's a rather larger refactor job

@TrueBrain TrueBrain merged commit 5f1154e into OpenTTD:master Jan 9, 2021
7 checks passed
@TrueBrain TrueBrain deleted the red-when-stopped branch Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants