Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: provide a visual representation of the company colour ranges #8546

Merged
merged 2 commits into from Apr 24, 2021

Conversation

andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Jan 9, 2021

Motivation / Problem

As part of #8539 Truebrain sought a representation of the company colours.

Description

Per #8539 (comment)

It was quite trivial to generate html from the Iron Horse compile as it already has in scope the company colours and a method for rgb values from palette indexes.

I've put it online at https://grf.farm/misc/company_colour_indexes.html but I don't guarantee that's stable, so we might want it in /docs for future travellers.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link
Member

@LordAro LordAro left a comment

Can we use some inline css classes to reduce some duplication?

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 22, 2021

Clearly it is a generated document, but I agree. If we want this in our codebase, we should deduplicate it a bit. Should be a simply search/replace for most part.

@TrueBrain TrueBrain added size: small work: minor details and removed needs review labels Jan 22, 2021
Copy link
Member

@TrueBrain TrueBrain left a comment

Squash when merging, and commit checker should be happy :)

@TrueBrain TrueBrain merged commit d0e40ab into OpenTTD:master Apr 24, 2021
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: small work: minor details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants