Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: On regression failure, output the result in a file #8549

Merged
merged 1 commit into from Jan 9, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Jan 9, 2021

Motivation / Problem

When regression test fails, sometimes our basic diff is not the most usable output. Especially when you are adding more checks to regression test. Having the output in a file can allow use of more avanced tools to compare it with expected output.

Description

On failure simply save the output to a file.
But first I needed to add support for more output lines than expected.
And while in the area I moved the counter increment before diff output, so lines are numbered from 1.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

LordAro
LordAro approved these changes Jan 9, 2021
@glx22 glx22 merged commit 97d554f into OpenTTD:master Jan 9, 2021
7 checks passed
@glx22 glx22 deleted the regression branch Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants