Move "town name" selection into map generator GUI #8566
Conversation
…ee window, and give it the same 'basic' visibility as 'in-game tree placement'.
…ve it the same 'basic' visibilty as 'signal side'.
Easy +1 from me. I did use the 'thumbs up' on the PR, but I don't really trust that as a process yet. |
STR_GAME_OPTIONS_ROAD_VEHICLES_DROPDOWN_LEFT :Drive on left | ||
STR_GAME_OPTIONS_ROAD_VEHICLES_DROPDOWN_RIGHT :Drive on right |
Comment on lines
950
to
951
LordAro
Jan 16, 2021
Member
I wonder if the remaining string ids should be renamed, given they're no longer in the game options
I wonder if the remaining string ids should be renamed, given they're no longer in the game options
uint gen = _settings_newgame.game_creation.town_name; | ||
StringID name = gen < BUILTIN_TOWNNAME_GENERATOR_COUNT ? | ||
STR_GAME_OPTIONS_TOWN_NAME_ORIGINAL_ENGLISH + gen : | ||
GetGRFTownNameName(gen - BUILTIN_TOWNNAME_GENERATOR_COUNT); |
LordAro
Jan 16, 2021
Member
pedantry: not sure i agree with the line splitting here. All on one line, or split with the ?
/:
as the first character
pedantry: not sure i agree with the line splitting here. All on one line, or split with the ?
/:
as the first character
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Motivation / Problem
There have been plenty of attempts to redesign the map generation window. Most get derailed into wanting to change everything.
This PR deals with two "world generation" settings:
Both settings do not belong into "game options". The most reported issue related to NewGRF town names is, that players do not "find" the "town name" dropdown to enable them.
Description
Main change:
Collateral changes:
Limitations
None.
Checklist for review
N/A