Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Actions] Give Universal Mac packages the "universal" suffix #8585

Merged
merged 1 commit into from Jan 18, 2021

Conversation

@orudge
Copy link
Contributor

@orudge orudge commented Jan 17, 2021

Motivation / Problem

I updated the macOS release action to generate a universal build, but the .dmg still has the x86_64 suffix.

Description

Rather than manually attempting to rename the .dmg after creation, I have added in a flag to indicate a universal build will be created.

Eventually this flag could perhaps be used to actually include the lipo step (if the path to the existing build is specified, a bit like we do with host build tools).

Limitations

A user creating a universal build currently has to manually glue things together, this flag will not change that. It purely affects the naming.

@orudge orudge merged commit 2d9e164 into OpenTTD:master Jan 18, 2021
7 checks passed
7 checks passed
Emscripten
Details
Commit checker
Details
Linux (clang, clang++)
Details
Linux (gcc, g++)
Details
Mac OS (x64, x86_64)
Details
Windows (x86)
Details
Windows (x64)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants