Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8589, 653e7fa548: Motion counter is NewGRF-visible but not saved, leading to desyncs. #8591

Merged
merged 1 commit into from Jan 18, 2021

Conversation

@michicc
Copy link
Member

@michicc michicc commented Jan 18, 2021

Motivation / Problem

Vehicle motion counter is NewGRF-accessible, but not stored in saves. This can lead to desyncs, see #8589.

Description

Store motion counter in saves to make access desync safe. Motion counter was not touched since its initial r6532.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
…eading to desyncs.
@michicc michicc merged commit 7da224d into OpenTTD:master Jan 18, 2021
8 checks passed
8 checks passed
Check for preview label
Details
Emscripten
Details
Commit checker
Details
Linux (clang, clang++)
Details
Linux (gcc, g++)
Details
Mac OS (x64, x86_64)
Details
Windows (x86)
Details
Windows (x64)
Details
@michicc michicc deleted the michicc:pr/motion_counter branch Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants