Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Create .zip for macOS build #8614

Merged
merged 1 commit into from Jan 28, 2021
Merged

Feature: Create .zip for macOS build #8614

merged 1 commit into from Jan 28, 2021

Conversation

@orudge
Copy link
Contributor

@orudge orudge commented Jan 28, 2021

Motivation / Problem

Offers a .zip option for macOS users who prefer that to .dmg.

Description

The app is already notarised as part of the dmg by gon. We now manually staple the notarisation token to the .app in the CPack build directory, then zip up the .app (rather than trying to run a separate CPack process with a zip generator).

Limitations

The .zip file itself can’t be stapled to, but this is a file format/macOS limitation, and shouldn’t affect the user.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@orudge orudge requested a review from TrueBrain Jan 28, 2021
@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 28, 2021

PS: as we are going to publish these files, please don't forget to update the descriptions in the website repo! :)

Copy link
Member

@TrueBrain TrueBrain left a comment

Commit message:
I am not sure I would consider this a Feature. That sounds like a bit too much for something this little. How about Add?

And please add [Actions] in the commit message; makes it easier for who-ever writes the changelogs :)

My suggestion:

Add: [Actions] Also produce macOS builds in .zip format

.github/workflows/release.yml Show resolved Hide resolved
@orudge orudge merged commit 1187dc3 into OpenTTD:master Jan 28, 2021
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants