Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: [Actions] we no longer need xdg-basedir #8615

Merged
merged 1 commit into from Jan 29, 2021

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 29, 2021

Motivation / Problem

Open a file, read something I wasn't expected, think about it once, think about it twice, realise we really did a poor job, fix it, leave the commit in the wrong branch for a few days, get reminded by it again, finally manage to PR it. Pfft.

Description

This was already removed from the "ci-build", but not yet from
"release".

Should have been done with 3dfee97#diff-68ba9d12f6f2601fe3c9f7f9d0d02aaea52384559d6d08fae7afc941663fdfcd , but here we are :)

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

This was already removed from the "ci-build", but not yet from
"release".
Copy link
Member

@LordAro LordAro left a comment

:)

@TrueBrain TrueBrain merged commit 4831b4f into OpenTTD:master Jan 29, 2021
7 checks passed
@TrueBrain TrueBrain deleted the cleanup-release branch Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants