Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2db88953: default Network Server List sorter put compatible servers in wrong order #8626

Merged
merged 1 commit into from Jan 31, 2021

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 31, 2021

Motivation / Problem

A user on IRC reported a very vague problem (as in, it was not understandable), but luckily is triggered @ldpl .. turns out that the whole 1.10 series had the default sorter sorting wrong. Honest mistake in a codechange commit, simple fix. For some reason nobody had done so, so here we are.

Description

If a server is compatible, it falls back to sorting by clients.
This used to be in reverse, so full servers are on top. With
the codechange commit, this was removed by accident, and as
such empty servers were on top. This is silly.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

…s in wrong order

If a server is compatible, it falls back to sorting by clients.
This used to be in reverse, so full servers are on top. With
the codechange commit, this was removed by accident, and as
such empty servers were on top. This is silly.
@TrueBrain TrueBrain merged commit 7fbf705 into OpenTTD:master Jan 31, 2021
7 checks passed
@TrueBrain TrueBrain deleted the network_sorter branch Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants