Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [CMake] Restore 'games' as default install bindir #8629

Merged
merged 1 commit into from Feb 7, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Jan 31, 2021

Closes #8599

Motivation / Problem

On Debian-based distributions, the executable should go to <prefix>/games, not <prefix>/bin.
Before switching to CMake, our old configure used to default to <prefix>/games.
Our CMake script uses GNUInstallDirs, which defaults to <prefix>/bin

Description

I restored games as default install bin dir, like it was in configure. We already set default data dir to share/games anyway.

Limitations

Package maintainers will need to set CMAKE_INSTALL_BINDIR if default doesn't match their target OS, but they are already used to do similar with the old configure.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

LordAro
LordAro approved these changes Feb 7, 2021
@glx22 glx22 merged commit f7ac296 into OpenTTD:master Feb 7, 2021
7 checks passed
@glx22 glx22 deleted the fix_8599 branch Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants