Feature: [GS] Allow non-question type windows to have no buttons #8638
Motivation / Problem
3 out of 4 gs "question" window types (info, warning and error) aren't really questions and likely don't need any buttons but are forced by gs api to have at least one.
GS for testing: test-question-no-buttons.zip
It still looks somewhat different from the regular error because of how paddings are calculated but I decided to address it in a separate pr later.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.
Small-caliber news, frequent ones don't actually require it.
One problem with closing the window is also that closing by RMB (the best change of the last 6 years for me) is not the default. This is a very big improvement not available to beginners. Also for this reason, removing the larger closing space of the window will not be good in my opinion.
Generally, it is not important to me, but I am writing it with people starting their adventure with the game in mind.
I hope, this will not getting a boomerang UI-wise because the close-window-cross-button is in comparision to the now removed OK-button a really small sized click target.
When an overlay has a ok-button, one as a player has three choices to close the overlay window, waiting until the window disappears, pushing the small close-window-cross-button or pushing the much bigger OK-button. Without the OK-button only waiting or pushing the small sized close-window-cross-button left.
We will see.
It's not been removed, merely the option to have one has been removed. It's on the GS author whether they use it or not, as appropriate.
I agree that the close button is small, but there are 'workarounds' - increased UI size or there's a setting to close windows on right-click too