Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Allow translation of "(Directory)" and "(Parent directory)" #8639

Merged
merged 1 commit into from Feb 14, 2021

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Feb 2, 2021

Closes #8636

Motivation / Problem

As reported in #8636, (Directory) and (Parent directory) in file lists are untranslatable.

Description

I made them translatable.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@glx22 glx22 force-pushed the glx22:translatable_file_list branch from d1911f1 to b71809a Feb 2, 2021
@glx22 glx22 force-pushed the glx22:translatable_file_list branch from b71809a to f9af9c9 Feb 7, 2021
src/lang/english.txt Outdated Show resolved Hide resolved
@Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Feb 8, 2021

I agree that ".." should not be localized at all. The ".." is a special directory name on Linux and doesn't change per-language.

@glx22 glx22 force-pushed the glx22:translatable_file_list branch from f9af9c9 to c9383f8 Feb 14, 2021
@glx22 glx22 merged commit 45e8b7a into OpenTTD:master Feb 14, 2021
10 checks passed
10 checks passed
@github-actions
Emscripten
Details
@github-actions
Commit checker
Details
@github-actions
Check preview needs update Check preview needs update
Details
@github-actions
Linux (clang, clang++)
Details
@github-actions
Linux (gcc, g++)
Details
@github-actions
Mac OS (x64, x86_64)
Details
@github-actions
Windows (windows-latest, x86)
Details
@github-actions
Windows (windows-latest, x64)
Details
@github-actions
Windows (windows-2016, x86) Windows (windows-2016, x86)
Details
@github-actions
Windows (windows-2016, x64) Windows (windows-2016, x64)
Details
@glx22 glx22 deleted the glx22:translatable_file_list branch Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants