Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: [CMake] Bump minimal version to 3.9 #8643

Merged
merged 2 commits into from Feb 7, 2021
Merged

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Feb 5, 2021

Motivation / Problem

With CMake minimum version set to anything before 3.9, for some unknown reason (maybe vcpkg as it happens only for Windows and MacOS targets), CMP0069 policy is reset between CMake configuration and generation steps.
This triggers a CMake warning and cause INTERPROCEDURAL_OPTIMIZATION property to be ignored.

Description

Since IPO support detection and CMP0069 policy were introduced in 3.9, it's simpler to set the minimum CMake version and get working interprocedural optimisation.
CMake 3.7 introduced a FindICU module, but our own module is better. So I kept our own, with a notice about why we don't use CMake provided module.
I also updated COMPILING.md to indicate minimum CMake version, and some hints for MSVC users when libraries are installed but not found.

Limitations

Some linux distribution may only have older CMake version as standard, but I think on most there's a way to update it.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

LordAro
LordAro approved these changes Feb 7, 2021
@glx22 glx22 merged commit af0acc9 into OpenTTD:master Feb 7, 2021
7 checks passed
@glx22 glx22 deleted the cmake_minimal branch Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants