Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [CMake] os/windows/openttd.manifest is not a generated file #8645

Merged
merged 1 commit into from Feb 5, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Feb 5, 2021

Motivation / Problem

os/windows/openttd.manifest is deleted when cleaning or rebuilding with MSVC

Description

os/windows/openttd.manifest was considered as a generated file, while it is not.
I fixed that.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

LordAro
LordAro approved these changes Feb 5, 2021
@glx22 glx22 merged commit 99448ee into OpenTTD:master Feb 5, 2021
7 checks passed
@glx22 glx22 deleted the manifest branch Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants