Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: [Actions] Document better why we build our own fluidsynth #8646

Merged
merged 1 commit into from Feb 5, 2021

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Feb 5, 2021

Motivation / Problem

Don't tell lies in comments.

Description

nielsmh nicely correct us in #8641, pointing out the old comment
is not telling a complete truth. The result, is the same, but it
is better to not mislead future-us.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

nielsmh nicely correct us in OpenTTD#8641, pointing out the old comment
is not telling a complete truth. The result, is the same, but it
is better to not mislead future-us.
nielsmh
nielsmh approved these changes Feb 5, 2021
@TrueBrain TrueBrain merged commit 4f0692c into OpenTTD:master Feb 5, 2021
7 checks passed
@TrueBrain TrueBrain deleted the fix-a-lie branch Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants